fix: Fix Windows zip file

[tianfeng92]

Proposed changes

When triggering tests on a Mac platform from a Windows machine, there is an issue with unzipping packages that have an @ prefix in the node_modules zip.

Passed job: https://app.saucelabs.com/tests/979a262f57724f80b45de70392039333

After:

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Update (if none of the other choices apply)

Checklist

• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)
• I have updated the json schema (if appropriate)

Further comments

[mhan83]

So given that all docs say to explicitly use forward slashes, I'm confused whether this change actually fixes the issue. Kind of seems like it could be making things worse? How did you test this?

Given this node_modules:

node_modules
└── @saucelabs
    └── testcafe-reporter-saucelabs

On Windows, before your change, the archived directory would be node_modules\@saucelabs/testcafe-reporter-saucelabs (note the last separator is a /) since archive/zip is using path.Join instead of filepath.Join. And when unarchiving on Mac we would see this hierarchy (which matches what I see in the jira ticket):

└── node_modules
└── node_modules\@saucelabs
    └── testcafe-reporter-saucelabs

But after this change, the archived directory would be node_modules\@saucelabs\testcafe-reporter-saucelabs which, I think, would be unarchived like this on Mac? (I dunno I can't test this):

└── node_modules
└── node_modules\@saucelabs
└── node_modules\@saucelabs\testcafe-reporter-saucelabs

Makes me think maybe all we need here is filepath.ToSlash to make sure the path we give to Create always has forward slashes, regardless of platform... (https://pkg.go.dev/path/filepath#ToSlash)

[tianfeng92]

The root cause is

filepath.Rel(sourceDir, filepath.Dir(f))

returns node_modules\@cucumber on Windows.