Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure app is a path before archiving #787

Merged
merged 3 commits into from
May 29, 2023

Conversation

FriggaHel
Copy link
Contributor

Proposed changes

Ensure that App not a storage: link prior to archiving it.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have updated the json schema (if appropriate)

Further comments

@FriggaHel FriggaHel requested a review from a team as a code owner May 26, 2023 13:36
@FriggaHel FriggaHel added the bug Something isn't working label May 26, 2023
tianfeng92
tianfeng92 previously approved these changes May 26, 2023
@FriggaHel FriggaHel merged commit 85c8eca into main May 29, 2023
@FriggaHel FriggaHel deleted the DEVX-2340-fix-storage-link branch May 29, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants