-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add commands to work with api testing project vaults #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Give it the project name and it will return the vault
Read from stdin if '-' given
I'm on board with |
Co-authored-by: Alex Plischke <alex.plischke@saucelabs.com>
Co-authored-by: Alex Plischke <alex.plischke@saucelabs.com>
alexplischke
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds the following commands to work with an api testing project vault:
Types of changes
Checklist
Further comments
project
a flag and not a positional arg. I opted for that because a command likeget-variable
feels like it wants the variable-in-question as the positional arg. Having the project be positional felt a bit awkward and unintuitive. But we already have some commands that have a "resource" as a positional arg, e.gartifacts download JOB_ID FILE_PATTERN
. So if we prefer consistency, I'm happy to go that route.--project
is not specified and the terminal is a tty, user will be prompted to choose from a list of projects:set-variable
to take either a path to a file or-
to denote stdin. Accepting from stdin is slightly pedantic, but experienced cli users may expect it.