Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APIF-1427 renames methods for uploading tests to the cloud #761

Merged
merged 2 commits into from
May 2, 2023
Merged

APIF-1427 renames methods for uploading tests to the cloud #761

merged 2 commits into from
May 2, 2023

Conversation

flyingsaucervargas
Copy link
Contributor

Proposed changes

In APIT we have a feature called "Load Test", here we are renaming the method 'loadTest' to 'uploadTest' to prevent ambiguity.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have updated the json schema (if appropriate)

@flyingsaucervargas flyingsaucervargas requested a review from a team as a code owner April 27, 2023 13:45
@flyingsaucervargas flyingsaucervargas added the go Pull requests that update Go code label Apr 27, 2023
alexplischke
alexplischke reviewed Apr 27, 2023
View reviewed changes
internal/apitest/runner.go Outdated Show resolved Hide resolved
internal/apitest/runner.go Outdated Show resolved Hide resolved
@flyingsaucervargas
Copy link
Contributor Author

@alexplischke thanks for the feedback; I fixed the names to match what they do in the context of executing the local tests.

alexplischke
alexplischke reviewed May 1, 2023
View reviewed changes
Copy link
Contributor

@alexplischke alexplischke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a suggestion that'd follow the go convention better in this particular scenario 🙏

internal/apitest/runner.go Outdated Show resolved Hide resolved
internal/apitest/runner.go Outdated Show resolved Hide resolved
internal/apitest/runner.go Outdated Show resolved Hide resolved
internal/apitest/runner.go Outdated Show resolved Hide resolved
internal/apitest/runner_test.go Outdated Show resolved Hide resolved
internal/apitest/runner_test.go Outdated Show resolved Hide resolved
internal/apitest/runner_test.go Outdated Show resolved Hide resolved
internal/apitest/runner_test.go Outdated Show resolved Hide resolved
internal/apitest/runner_test.go Outdated Show resolved Hide resolved
internal/apitest/runner_test.go Outdated Show resolved Hide resolved
@flyingsaucervargas
Copy link
Contributor Author

@alexplischke done, I applied your suggestions.

alexplischke
alexplischke previously approved these changes May 2, 2023
View reviewed changes
@flyingsaucervargas
APIF-1427 renames methods for uploading tests to the cloud
68400b9 
In APIT we have a feature called "Load Test", here we are renaming
the method 'loadTest' to 'newTest' to prevent ambiguity.
@FriggaHel FriggaHel merged commit 026fdd1 into saucelabs:main May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexplischke alexplischke alexplischke approved these changes

Assignees
No one assigned
Labels
go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flyingsaucervargas @alexplischke @FriggaHel