Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Usage when PreRun fails #752

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Hide Usage when PreRun fails #752

merged 1 commit into from
Apr 24, 2023

Conversation

FriggaHel
Copy link
Contributor

@FriggaHel FriggaHel commented Apr 24, 2023

Proposed changes

On error, usage display makes it really easy to miss what actually failed.
By setting SilenceUsage, whenever an error occurs, no usage will be displayed, allowing to keep the actual error on sight.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have updated the json schema (if appropriate)

Further comments

@FriggaHel FriggaHel requested a review from a team as a code owner April 24, 2023 10:46
@FriggaHel FriggaHel added the documentation Improvements or additions to documentation label Apr 24, 2023
@FriggaHel FriggaHel merged commit 2abe293 into main Apr 24, 2023
@FriggaHel FriggaHel deleted the DEVX-2266-hide-usage branch April 24, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants