-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for HTTP_PROXY #738
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FriggaHel
commented
Apr 6, 2023
Validation needs another look?
|
alexplischke
reviewed
Apr 6, 2023
alexplischke
reviewed
Apr 6, 2023
@mhan83: This is fixed, this was a bug in AppStorage code ! |
alexplischke
reviewed
Apr 7, 2023
Co-authored-by: Alex Plischke <alex.plischke@saucelabs.com>
FriggaHel
force-pushed
the
DEVX-2239-add-support-for-proxies
branch
from
April 7, 2023 17:57
e50972e
to
c821c1d
Compare
alexplischke
approved these changes
Apr 7, 2023
mhan83
approved these changes
Apr 10, 2023
tianfeng92
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds support for HTTP_PROXY (including proxies with authentication).
Also checks
HTTP_PROXY
right at startup to ensure sanityTypes of changes
Checklist
Further comments