Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add saucectl imagerunner logs command #735

Merged
merged 7 commits into from
Apr 3, 2023
Merged

Add saucectl imagerunner logs command #735

merged 7 commits into from
Apr 3, 2023

Conversation

mhan83
Copy link
Contributor

@mhan83 mhan83 commented Apr 3, 2023

Proposed changes

Add saucectl imagerunner logs <runID> command to fetch the logs for a hosted test orchestration run.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have updated the json schema (if appropriate)

Further comments

Still a little uncertain about whether to have the imagerunner subcommand or not. If one day we want to have a logs command for non-HTO resources and we don't mind that saucectl logs overlaps with saucectl imagerunner logs for HTO runs, then I prefer scoping the command with the explicit imagerunner subcommand. If we want to avoid overlapping functionality, then I think we should just go with saucectl logs.

internal/imagerunner/imagerunner.go Outdated Show resolved Hide resolved
internal/http/imagerunner.go Outdated Show resolved Hide resolved
@alexplischke
Copy link
Contributor

Still a little uncertain about whether to have the hto subcommand or not.

Same.

@KunalJain Just going to lay out an overview:

If we namespace this one, but not artifact downloads, then we'll have:

  • saucectl artifacts download [...]
  • saucectl hto logs [...]

Consequences

  • Inconsistent

If we don't namespace:

  • saucectl artifacts download [...]
  • saucectl logs [...]

Consequences

  • The commands have to query a bunch of systems to figure out what this ID you passed in means, which product it belongs to.
  • User has only one interface to deal with.

If we namespace both:

  • saucectl artifacts download [...] for non-HTO
  • saucectl hto artifacts download [...]
  • saucectl hto logs [...]

Consequences

  • Inconsistent.
  • Consistency can be introduced later with a major breaking change, but one would have to come up with namespaces for the RDC/VDC API.

@mhan83 mhan83 marked this pull request as ready for review April 3, 2023 20:16
@mhan83 mhan83 requested a review from a team as a code owner April 3, 2023 20:16
@mhan83 mhan83 changed the title Add saucectl hto logs command Add saucectl imagerunner logs command Apr 3, 2023
@mhan83 mhan83 requested a review from alexplischke April 3, 2023 20:18
@mhan83 mhan83 merged commit 02dc5a5 into main Apr 3, 2023
@mhan83 mhan83 deleted the DEVX-2209 branch April 3, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants