Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix node release #732

Merged
merged 4 commits into from
Mar 30, 2023
Merged

Fix node release #732

merged 4 commits into from
Mar 30, 2023

Conversation

tianfeng92
Copy link
Contributor

@tianfeng92 tianfeng92 commented Mar 29, 2023 •
edited
Loading

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have updated the json schema (if appropriate)

Further comments

@tianfeng92 tianfeng92 marked this pull request as ready for review March 29, 2023 23:03
@tianfeng92 tianfeng92 requested a review from a team as a code owner March 29, 2023 23:03
@tianfeng92 tianfeng92 added the bug Something isn't working label Mar 29, 2023
alexplischke
alexplischke approved these changes Mar 29, 2023
View reviewed changes
.github/workflows/release.yml
Comment on lines +48 to +51
node-release:
runs-on: ubuntu-latest
needs: release
steps:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That wouldn't be necessary then, wouldn't it? Do you want to keep it separate?

@tianfeng92 tianfeng92 merged commit 403912a into main Mar 30, 2023
@tianfeng92 tianfeng92 deleted the fix-node-release branch March 30, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexplischke alexplischke alexplischke approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tianfeng92 @alexplischke