Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testcafe: Map missing *Timeout #730

Merged
merged 5 commits into from
Mar 30, 2023
Merged

testcafe: Map missing *Timeout #730

merged 5 commits into from
Mar 30, 2023

Conversation

FriggaHel
Copy link
Contributor

Proposed changes

Map *Timeout fields that are not currently present.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have updated the json schema (if appropriate)

Further comments

@FriggaHel FriggaHel requested a review from a team as a code owner March 29, 2023 07:42
alexplischke
alexplischke reviewed Mar 29, 2023
View reviewed changes
Copy link
Contributor

@alexplischke alexplischke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs schema update 🙏
There's technically also the CLI driven flags as well.

@FriggaHel FriggaHel merged commit b01e053 into main Mar 30, 2023
@FriggaHel FriggaHel deleted the DEVX-2041-map-timeout-configs branch March 30, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexplischke alexplischke alexplischke approved these changes

@tianfeng92 tianfeng92 tianfeng92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FriggaHel @alexplischke @tianfeng92