fix: Incorrect serialization of RDC appSettings caused them to never …

…take effect (#830)
saucelabs · Sep 1, 2023 · 2db4c2b · 2db4c2b
1 parent 58fab9a
commit 2db4c2b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/internal/http/rdcservice.go b/internal/http/rdcservice.go
@@ -67,7 +67,7 @@ type RDCSessionRequest struct {
 	UseTestOrchestrator bool              `json:"use_test_orchestrator,omitempty"`
 	Tags                []string          `json:"tags,omitempty"`
 	Build               string            `json:"build,omitempty"`
-	AppSettings         job.AppSettings   `json:"settings,omitempty"`
+	AppSettings         job.AppSettings   `json:"settings_overwrite,omitempty"`
 	RealDeviceKind      string            `json:"kind,omitempty"`
 }
 

diff --git a/internal/job/starter.go b/internal/job/starter.go
@@ -68,13 +68,13 @@ type StartOptions struct {
 
 // AppSettings represents app settings for real device
 type AppSettings struct {
-	AudioCapture    bool            `json:"audioCapture,omitempty"`
+	AudioCapture    bool            `json:"audio_capture,omitempty"`
 	Instrumentation Instrumentation `json:"instrumentation,omitempty"`
 }
 
 // Instrumentation represents instrumentation settings for real device
 type Instrumentation struct {
-	NetworkCapture bool `json:"networkCapture,omitempty"`
+	NetworkCapture bool `json:"network_capture,omitempty"`
 }
 
 // TunnelOptions represents the options that configure the usage of a tunnel when running tests in the Sauce Labs cloud.