Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove redundant console.log #305

Merged
merged 7 commits into from
Aug 19, 2024
Merged

chore: Remove redundant console.log #305

merged 7 commits into from
Aug 19, 2024

Conversation

tianfeng92
Copy link
Contributor

@tianfeng92 tianfeng92 commented Aug 16, 2024

Description

Remove redundant console.log.

Revise Cypress tests. npm run test doesn't trigger any test. Just rename the real integration test to test.

@tianfeng92 tianfeng92 marked this pull request as ready for review August 16, 2024 22:30
@tianfeng92 tianfeng92 requested a review from a team as a code owner August 16, 2024 22:30
Copy link
Contributor

@mhan83 mhan83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be removed too?

https://github.com/saucelabs/sauce-cypress-runner/blob/main/package.json#L8

Or do we need to keep bin/cypress? npm test runs it

@tianfeng92
Copy link
Contributor Author

This needs to be removed too?

https://github.com/saucelabs/sauce-cypress-runner/blob/main/package.json#L8

Or do we need to keep bin/cypress? npm test runs it

Nice catch. Let me check npm test.

@tianfeng92 tianfeng92 marked this pull request as draft August 16, 2024 23:21
@tianfeng92 tianfeng92 marked this pull request as ready for review August 16, 2024 23:48
@tianfeng92 tianfeng92 merged commit ec141ed into main Aug 19, 2024
30 checks passed
@tianfeng92 tianfeng92 deleted the DEVX-3007 branch August 19, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants