Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: downgrade to Node.js 20 #297

Merged
merged 9 commits into from
Jun 12, 2024
Merged

build: downgrade to Node.js 20 #297

merged 9 commits into from
Jun 12, 2024

Conversation

alexplischke
Copy link
Contributor

Description

Main change is to revert our target back to Node.js 20.

Additional changes:

  • Removed the unit-test step. I had already marked it optional in the past, since we only have integration tests. Removed it entirely now.
  • Eslint was misconfigured and didn't apply the Cypress configuration correctly at all. Fixed this and optimized it to only apply to our test files.

@alexplischke alexplischke marked this pull request as ready for review June 12, 2024 14:16
@alexplischke alexplischke requested a review from a team as a code owner June 12, 2024 14:16
@alexplischke alexplischke merged commit 75eaf6b into main Jun 12, 2024
28 of 30 checks passed
@alexplischke alexplischke deleted the DEVX-2922 branch June 12, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhan83 mhan83 mhan83 approved these changes

@tianfeng92 tianfeng92 tianfeng92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexplischke @mhan83 @tianfeng92