Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVX-1805] Expose additional env vars #194

Merged
merged 5 commits into from
Jul 19, 2022
Merged

[DEVX-1805] Expose additional env vars #194

merged 5 commits into from
Jul 19, 2022

Conversation

tianfeng92
Copy link
Contributor

@tianfeng92 tianfeng92 commented Jul 18, 2022

Add SAUCE_SUITE_NAME and SAUCE_ARTIFACTS_DIRECTORY

@tianfeng92 tianfeng92 marked this pull request as ready for review July 18, 2022 23:44
@tianfeng92 tianfeng92 requested a review from a team July 18, 2022 23:44
@tianfeng92 tianfeng92 changed the title [DEVX-1805] Add additional env vars [DEVX-1805] Expose additional env vars Jul 18, 2022
src/cypress-runner.js Outdated Show resolved Hide resolved
Copy link
Contributor

@alexplischke alexplischke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please try out whether those vars are accessible in user provided plugins as well? I know there were some issues with regards to setting env vars in cypress and them not be available depending on the context. Just want to make sure it's available for the entire process.

@tianfeng92 tianfeng92 merged commit 095afc1 into main Jul 19, 2022
@tianfeng92 tianfeng92 deleted the devx-1805 branch July 19, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants