Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary config copy #192

Merged
merged 3 commits into from
Jul 7, 2022
Merged

Conversation

tianfeng92
Copy link
Contributor

@tianfeng92 tianfeng92 commented Jul 7, 2022

Notice this warning msg for cypress 10

The following configuration option is invalid:

 - testingType

It's because of unnecessary config copy for cypress.run() and the result is like

cypressOpts:  {
  testingType: 'e2e',
  config: {
    specPattern: [ 'cypress/e2e/**/*.js' ],
    excludeSpecPattern: [],
    ...
    testingType: 'e2e'
  }
}

cypress throws warning for the nested testingType under config

@tianfeng92 tianfeng92 requested a review from a team July 7, 2022 00:02
@tianfeng92 tianfeng92 force-pushed the remove-unnecessary-copy-config branch from 627bd50 to 42b78e5 Compare July 7, 2022 01:22
@tianfeng92 tianfeng92 merged commit eae5b33 into main Jul 7, 2022
@tianfeng92 tianfeng92 deleted the remove-unnecessary-copy-config branch July 7, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants