Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(discord): update API to Aug 9, 2022 #61

Merged
merged 6 commits into from
Jan 11, 2023
Merged

feat(discord): update API to Aug 9, 2022 #61

merged 6 commits into from
Jan 11, 2023

Conversation

idranme
Copy link
Contributor

@idranme idranme commented Jan 8, 2023 •
edited
Loading

shigma
shigma reviewed Jan 8, 2023
View reviewed changes
Copy link
Contributor

@shigma shigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all thank you for your contribution!

The typings for discord adapter are regularly updated according to the changelog on the official website. We accept full updates rather than type patches. Our last update was on Jun 29, 2022 (c0a29e0). If you'd like to contribute a PR, please include the full typings as far as any time thereafter (up to Aug 9, 2022 is enough to cover your commits).

If you have any difficulties, simply close the PR and submit an issue instead, and I will find time to update the typings later.

@idranme
Copy link
Contributor Author

idranme commented Jan 8, 2023

First of all thank you for your contribution!

The typings for discord adapter are regularly updated according to the changelog on the official website. We accept full updates rather than type patches. Our last update was on Jun 29, 2022 (c0a29e0). If you'd like to contribute a PR, please include the full typings as far as any time thereafter (up to Aug 9, 2022 is enough to cover your commits).

If you have any difficulties, simply close the PR and submit an issue instead, and I will find time to update the typings later.

I will finish the work later.

@idranme idranme changed the title fix(discord): add resume_gateway_url to ReadyEvent feat(discord): update API to Aug 9, 2022 Jan 8, 2023
@idranme
Copy link
Contributor Author

idranme commented Jan 8, 2023

done

@idranme idranme requested a review from shigma January 8, 2023 19:28
@shigma shigma merged commit 11e8551 into satorijs:master Jan 11, 2023
@idranme idranme deleted the patch-1 branch January 11, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shigma shigma shigma approved these changes

Assignees
No one assigned
Labels
platform: discord
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@idranme @shigma