Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(satori): missing status, fix koishijs/koishi#1367, fix #241 #242

Merged
merged 4 commits into from
Mar 10, 2024

Conversation

Lipraty
Copy link
Member

@Lipraty Lipraty commented Feb 26, 2024

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.93%. Comparing base (e5825f1) to head (06cd7b1).
Report is 14 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #242      +/-   ##
==========================================
+ Coverage   86.88%   86.93%   +0.04%     
==========================================
  Files           1        1              
  Lines         549      551       +2     
  Branches      111      111              
==========================================
+ Hits          477      479       +2     
  Misses         72       72              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lipraty
Copy link
Member Author

Lipraty commented Feb 26, 2024

? 怎么 CI 爆了

@Lipraty Lipraty changed the title fix: set bot status of global fix: missing status in satori Feb 26, 2024
@MaikoTan
Copy link
Member

MaikoTan commented Mar 7, 2024

? 怎么 CI 爆了

Looks like the yakumo should be updated, but overall the PR looks good to me.

adapters/satori/src/ws.ts Outdated Show resolved Hide resolved
@shigma shigma changed the title fix: missing status in satori fix(satori): missing status in satori, fix koishijs/koishi#1367, fix #241 Mar 9, 2024
@Lipraty
Copy link
Member Author

Lipraty commented Mar 9, 2024

Testing is completed and the following issues have been fixed:

  • missing status
  • WebUI normal display login status

@Lipraty Lipraty requested a review from shigma March 9, 2024 15:59
adapters/satori/src/ws.ts Outdated Show resolved Hide resolved
@shigma shigma changed the title fix(satori): missing status in satori, fix koishijs/koishi#1367, fix #241 fix(satori): missing status, fix koishijs/koishi#1367, fix #241 Mar 10, 2024
@shigma shigma merged commit 94d40c5 into satorijs:master Mar 10, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants