Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add travis ci #4

Merged
merged 5 commits into from
Nov 9, 2017
Merged

Add travis ci #4

merged 5 commits into from
Nov 9, 2017

Conversation

gilgamezh
Copy link
Contributor

  • travis CI
  • coveralls.io

@coveralls
Copy link

coveralls commented Nov 8, 2017 •
edited
Loading

Coverage Status

Changes Unknown when pulling 8abc822 on add_travis_ci into ** on master**.

@gilgamezh
Copy link
Contributor Author

badges added to README

image

to merge test are required

image

@coveralls
Copy link

coveralls commented Nov 8, 2017 •
edited
Loading

Coverage Status

Changes Unknown when pulling 3d20e9b on add_travis_ci into ** on master**.

astrojuanlu
astrojuanlu reviewed Nov 8, 2017
View reviewed changes
.travis.yml Outdated
- "3.6-dev"
- "nightly" # currently points to 3.7-dev
install:
- "pip install -r requirements.txt"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bear in mind that pip install -e .[dev] already does this. I prefer the shorter method but won't argue much about it, however we should probably be consistent with CONTRIBUTING.md and avoid duplicating the places where we specify the dependencies.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! I'm removing it.

And what about the requirements-test.txt?

@coveralls
Copy link

coveralls commented Nov 8, 2017 •
edited
Loading

Coverage Status

Changes Unknown when pulling 13905ac on add_travis_ci into ** on master**.

@astrojuanlu
Copy link
Contributor

astrojuanlu commented Nov 8, 2017 via email

@matiasg
Copy link
Collaborator

matiasg commented Nov 8, 2017

@gilgamezh is the travis.yml correct?
I'm seeing this in travis site:

__________________ ERROR collecting tests/test_quaternions.py __________________
ImportError while importing test module '/home/travis/build/satellogic/quaternions/tests/test_quaternions.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
tests/test_quaternions.py:6: in <module>
    from quaternions import Quaternion, QuaternionError
E   ImportError: No module named 'quaternions'
!!!!!!!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!!!!!!!

astrojuanlu
astrojuanlu approved these changes Nov 8, 2017
View reviewed changes
Copy link
Contributor

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@astrojuanlu
Copy link
Contributor

@matiasg where are you seeing that? Here all the status checks passed.

@coveralls
Copy link

coveralls commented Nov 9, 2017 •
edited
Loading

Coverage Status

Changes Unknown when pulling 425aea3 on add_travis_ci into ** on master**.

@gilgamezh gilgamezh merged commit 28dba2a into master Nov 9, 2017
@matiasg
Copy link
Collaborator

matiasg commented Nov 9, 2017

@Juanlu001 , I was looking at the first commit in the PR. My bad, had to look at the last one.

@astrojuanlu astrojuanlu deleted the add_travis_ci branch November 9, 2017 14:41
@astrojuanlu astrojuanlu restored the add_travis_ci branch November 9, 2017 14:41
@astrojuanlu
Copy link
Contributor

Sorry, wrong button :)

@enritoomey enritoomey deleted the add_travis_ci branch March 19, 2020 23:54
matiasg added a commit that referenced this pull request Jul 27, 2020
@matiasg
# This is a combination of 24 commits.
e4fada6 
# This is the 1st commit message:

pin coveralls version

# This is the commit message #2:

rever change of pytest-coverage. Pin python-coverage

# This is the commit message #3:

just as a test, remove coveralls

# This is the commit message #4:

remove also cov from script 🤦

# This is the commit message #5:

pin pytest version

# This is the commit message #6:

pin hypothesis version

# This is the commit message #7:

pin hypothesis to 3.55.1 now

# This is the commit message #8:

do not install pytest-coverage

# This is the commit message #9:

pin pytest-coverage

# This is the commit message #10:

install pinned coverage, do not install pytest-coverage :'(

# This is the commit message #11:

pin attr

# This is the commit message #12:

attr is attrs

# This is the commit message #13:

travis, please tell me attr version

# This is the commit message #14:

go back to original setup.py

# This is the commit message #15:

exclude coveralls from 3.4 & 3.5. Try 1

# This is the commit message #16:

use [] instead of test

# This is the commit message #17:

install pytest 5.4.3

# This is the commit message #18:

travis tell me something

# This is the commit message #19:

please do tell

# This is the commit message #20:

ooohhh?

# This is the commit message #21:

oh 2

# This is the commit message #22:

oh 3

# This is the commit message #23:

oh 4

# This is the commit message #24:

oh 5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astrojuanlu astrojuanlu astrojuanlu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gilgamezh @coveralls @astrojuanlu @matiasg