Fix pecoff signing with post-header gap and unaligned last section #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some compilers (e.g. Delphi) may produce output where the last section is not padded at all. This change will prevent the recalculation of SizeOfRawData for the last section. In case the compiler does add a padding, we will read it in the "readTrailer" function. Signed-off-by: Leonhard Oelke <leonhard@in-verted.de>
It is possible for binaries to have a "gap" between the PE header and the start of the first section. This change will handle those files by digesting the "gap". Signed-off-by: Leonhard Oelke <leonhard@in-verted.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to sign one of our binaries, we ran into two separate issues. The binary has two unusual features:
The proposed changes fix the signing (and verification) for our binary.