Skip to content
This repository has been archived by the owner on Aug 26, 2022. It is now read-only.

Test suite fails on rpm tests #2

Open
csams opened this issue May 8, 2019 · 2 comments · May be fixed by #3
Open

Test suite fails on rpm tests #2

csams opened this issue May 8, 2019 · 2 comments · May be fixed by #3

Comments

@csams
Copy link

csams commented May 8, 2019

____________________________________________________________________________ VersionCompareTest.test_from_rpmtest _____________________________________________________________________________

self = <rpm_vercmp.tests.vercmp_test.VersionCompareTest testMethod=test_from_rpmtest>

    def test_from_rpmtest(self):
        parser = ACParser(self.acfobj, with_buggy_comparisons=True)
        test_count = 0
        for first, second, exp in parser:
            test_count += 1
            ret = rpm_vercmp.vercmp(first, second)
>           self.assertEqual(exp, ret)
E           AssertionError: 1 != 0

rpm_vercmp/tests/vercmp_test.py:104: AssertionError

The failure happens for "1.0^" and "1.0"

Maybe due to these commits?

@vzhestkov
Copy link

Fix is in #3

@vzhestkov vzhestkov linked a pull request Oct 25, 2021 that will close this issue
pombredanne added a commit to aboutcode-org/univers that referenced this issue Dec 7, 2021
The isue has been fixed the previous merge

Reference: #2
Reference: sassoftware/python-rpm-vercmp#2
Reference: sassoftware/python-rpm-vercmp#4
Reported-by: Shivam Sandbhor @sbs2001
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants