Windows: Add editorconfig and fix filterpaths for latest libsass #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add missing LIBSASS_INCLUDES_DIR property - Fix AdditionalIncludeDirectories so base.h and the other include\sass files are found - Update filter paths from latest libsass.targets - Changes LIBSASS_DIR to a peer folder instead of a parent directory
|
Whoa some of that stuff was ancient |
|
Yeah, I'll take a look at setting up Appveyor later, but I thought I'd get it building again separately |
|
Do you have commit privileges? If so 🚢 |
|
Nope, just node-sass, but I usually try to avoid self-merging my stuff. It's shared blame when stuff blows up then 😜 |
|
Build stuff is mostly gibberish to me, but I'll peek my head into any PR emails when I have a moment. |
|
If you're in the area, getting CI setup would be 👌 for lowering risk of self-merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
files are found