-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix build for mingw32 #172
Conversation
Otherwise is_mingw32 is set too late and configure fails with missing dlopen().
cf31f03
to
d262eff
Compare
Are you sure both lines need to be moved? Some info about your system would also be helpfull. We use the same pattern in other places. So I would like to know exactly if only the |
For my use case only the I figured that since both lines are related, it would be better to keep them together, but I admit I gave it very little thought. If you prefer it any other way, I'm happy to force-push a different version here. |
I need to further check this. My first try with msys2 lead to the opposite direction as your fix. I so far tried only libsass build. Needed to patch it for mingw64, but once it was working I moved the check as you did and then it started to fail. Indicating that the checks are actually also needed for mingw. But I need to further check if this is dependent on msys or not. |
hmm... that's odd. I've just cloned current sassc master and tried building with
The configure fails as follows
The reason for this is clear, I think. On line 60 in Anyway, current |
I'm currently testing https://github.com/sass/libsass/blob/master/configure.ac. There is another fix needed for mingw64 as it now reports as mingw64. I'm pretty sure in some earlier tests I did it also reported as mingw32, but I might be wrong. Can you check #174? As you see I removed the if for the check on top. I doesn't seem to be needed (in fact I guess that it made the build fail once I moved the check above). But I agree that the other check must be above the actual use, so that was indeed a bug. |
Otherwise
is_mingw32
is set too late and configure fails with missingdlopen()
.