Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on full Rails #52

Merged
merged 1 commit into from
Jan 20, 2016
Merged

Remove dependency on full Rails #52

merged 1 commit into from
Jan 20, 2016

Conversation

rosenfeld
Copy link
Contributor

railties has most of Rails dependencies and will not depend on activerecord for example. Since we use Sequel rather than ActiveRecord, requiring sassc was the culprit for adding activerecord to the bundle for no good reason.

`railties` has most of Rails dependencies and will not depend on `activerecord` for example. Since we use Sequel rather than ActiveRecord, requiring sassc was the culprit for adding activerecord to the bundle for no good reason.
@bolandrm
Copy link
Member

bolandrm commented Jan 4, 2016

Hey, thanks for the PR. Looks like there are some version related test failures.

@rosenfeld
Copy link
Contributor Author

I don't think the errors are related to my changes. I followed the commands displayed in the travis-ci log and omitted the part that pulls from this PR and I got exactly the same errors.

@k0kubun
Copy link

k0kubun commented Jan 10, 2016

Builds for rails 4.2 are failing because sprockets-rails 3.0 is installed only in 4.2 builds and we need rafaelfranca@c85db78 in #41 to pass tests with sprockets-rails 3.0.

@bolandrm
Copy link
Member

Thanks!

bolandrm added a commit that referenced this pull request Jan 20, 2016
Remove dependency on full Rails
@bolandrm bolandrm merged commit 368186c into sass:master Jan 20, 2016
@rosenfeld
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants