Drop the non-nullability annotation from the Dart Sass wrapper #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like we may not need this anymore, and it's breaking the Dart Dev CI.
jathak
approved these changes
Dec 8, 2022
|
@nex3 I will close my PR, but there is one more annotation at this line: https://github.com/sass/sass-spec/pull/1847/files#diff-379fe16390a390114f3729d87a4a207f747c985df810fe20c25fd976c1abcf6aL69 |
|
Ah sorry @ntkme, I didn't notice you had a PR for this. The Ruby file is essentially unused at this point and we should probably just delete that runner entirely. |
|
@nex3 No worries. I think in this case we can just rerun failed CI for release without needing to cut another one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like we may not need this anymore, and it's breaking the Dart
Dev CI.