-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for color.is-legacy() #1842
Conversation
Co-authored-by: david herron <41588129+dvdherron@users.noreply.github.com>
… hex, name, and alpha colors
We should target these color space PRs to separate branch ( |
@nex3 I don't think we have the right access here to make a new branch. If you create the branch I can re-target these color PRs. |
@dvdherron Done 😃. I ended up naming it @SondraE You should be able to fix the lint errors by running |
================================================================================ | ||
<===> error/too_few_args/input.scss | ||
@use "sass:color"; | ||
a {b: color.is-legacy(rgb(0 255))} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is passing too few args to rgb()
, but it should be passing too few args to is-legacy()
================================================================================ | ||
<===> named/input.scss | ||
@use "sass:color"; | ||
a {b: color.is-legacy($color: midnightblue)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this is testing both a named argument and a named color—we should have separate tests for each of these cases (see https://github.com/sass/sass-spec/blob/main/STYLE_GUIDE.md#do-test-only-one-thing-per-spec)
Removing |
JS API test failures are unrelated, I'm working on fixing them in #1853 |
Part of tests for color spaces.
See sass/sass#2831