Add specs for the new JS importer API #1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nex3
force-pushed
the
importer-specs
branch
6 times, most recently
from
52aac30 to
9017087
Compare
Awjin
approved these changes
Oct 5, 2021
| }); | ||
| }); | ||
|
|
||
| describe('fromImport is', () => { |
There was a problem hiding this comment.
Should this also test @forward and meta.load-css?
There was a problem hiding this comment.
Since we're already testing those for normal importers, I think it's fine to rely on this behavior being the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See sass/sass#2509
[skip dart-sass]