Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the module system in existing files #359

Merged
merged 5 commits into from
Aug 29, 2019
Merged

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Aug 21, 2019

No description provided.

Documentation for @use and @forward themselves will come in a future
PR.

Partially addresses #263
source/documentation/at-rules/import.html.md.erb Outdated Show resolved Hide resolved
source/documentation/at-rules/import.html.md.erb Outdated Show resolved Hide resolved
source/documentation/at-rules/import.html.md.erb Outdated Show resolved Hide resolved
source/documentation/at-rules/import.html.md.erb Outdated Show resolved Hide resolved
source/documentation/at-rules/import.html.md.erb Outdated Show resolved Hide resolved
source/documentation/at-rules/import.html.md.erb Outdated Show resolved Hide resolved
#### How Do I Migrate?

We've written a [migration tool][] that can automatically convert most
`@import`-based code to `@use`-based code in a flash. Just point it at your
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"in a flash" is an idiom you might want to avoid
(generally want to avoid idioms in technical writing)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree in general, but I think striking a bit more of a conversational tone here (since it's a callout explaining why people should exert effort changing) is worth it.

This keeps the link-checker from complaining about links to pages that
don't exist yet.
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nex3 nex3 merged commit 2088a02 into feature.use Aug 29, 2019
@nex3 nex3 deleted the ancillary-module-docs branch August 29, 2019 22:31
@nex3 nex3 changed the title Add an implementation note about sass/libsass#2957 Document the module system in existing files Sep 2, 2019
asaf400 pushed a commit to asaf400/ass-site that referenced this pull request Apr 18, 2024
Documentation for @use and @forward themselves will come in a future
PR.

Partially addresses sass#263
asaf400 pushed a commit to asaf400/ass-site that referenced this pull request Apr 18, 2024
Documentation for @use and @forward themselves will come in a future
PR.

Partially addresses sass#263
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants