-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
Sorry for the slow response @deepak1556 😦 @andrew this should cover off most of our CI binary building 🎆 We can request Travis flip the bit to allow OSX+Ubuntu matrix building (and therefore cover off everything but the 32bit Ubuntu building). |
@nschonni that sounds wonderful! |
@deepak1556 I've rebased this down, but I have failing tests one both AppVeyor and locally. These failures don't appear related to the PR, but since it also is marking the build as passed with failing tests I'd like to resolve that issue first. |
- x86 | ||
|
||
install: | ||
- ps: Update-NodeJsInstallation (Get-NodeJsLatestBuild $env:nodejs_version) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating Node on Appveyor takes an awful lot of time & I suppose it doesn't matter here if we're testing on Node 0.10.28 or 0.10.29. I'd advise to use the following pattern:
https://github.com/mzgol/check-dependencies/blob/6519b54cad6f8f4142947b5ec4efe46b0803fdef/appveyor.yml#L16
In this way, if the major & minor numbers match, the update is not performed.
+1 for the Appveyor setup! |
@deepak1556 would you care to rebase this pr so we can look at merging it?
|
@andrew done, can you takecare of the url to the appveyor badge in the readme before merging it ? |
Nice! thanks @deepak1556 ! Momentarily, please rebase it against upstream's master (it will remove the merge commits as well): git remote add node-sass https://github.com/sass/node-sass/
git pull --rebase node-sass master Revert this change: https://github.com/sass/node-sass/pull/359/files#diff-0cd0d10017fa41b04681b81e5838edacR160, then: git commit --amend
# close the editor and finally:
git push -f
# to rewrite the history .. |
a7337c0
to
e072307
Compare
@am11 done. |
Thanks! 👍 @andrew LGTM! Should we merge it in? |
@deepak1556, have you considered @mzgol's comment? Wouldn't it be nice to prevent unnecessary update by replacing appveyor.yml : line 13 with:
|
Merge-tastic! |
👍 , @am11 yea i did consider it, but i wanted to leave the decision to you guys :) |
Allow trailing commas in lists. Fixes sass#359
Need to change the
project_id
inappveyor.yml
and badge url in Readme . If there is an interest in switching tonode-pre-gyp
for the binaries, i can pitch in a separate PR for it :)@nschonni