Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Appveyor setup #359

Merged
merged 3 commits into from
Sep 6, 2014
Merged

Appveyor setup #359

merged 3 commits into from
Sep 6, 2014

Conversation

deepak1556
Copy link
Contributor

Need to change the project_id in appveyor.yml and badge url in Readme . If there is an interest in switching to node-pre-gyp for the binaries, i can pitch in a separate PR for it :)

@nschonni

@nschonni nschonni self-assigned this Jul 4, 2014
@nschonni nschonni added this to the v0.10.0 milestone Jul 4, 2014
@nschonni
Copy link
Contributor

nschonni commented Jul 4, 2014

Sorry for the slow response @deepak1556 😦
I'm assigning this to myself to review this weekend, but don't let that stop other contributors from merging if you think it is ready to go.


@andrew this should cover off most of our CI binary building 🎆 We can request Travis flip the bit to allow OSX+Ubuntu matrix building (and therefore cover off everything but the 32bit Ubuntu building).

@andrew
Copy link
Contributor

andrew commented Jul 7, 2014

@nschonni that sounds wonderful!

@nschonni
Copy link
Contributor

@deepak1556 I've rebased this down, but I have failing tests one both AppVeyor and locally. These failures don't appear related to the PR, but since it also is marking the build as passed with failing tests I'd like to resolve that issue first.

- x86

install:
- ps: Update-NodeJsInstallation (Get-NodeJsLatestBuild $env:nodejs_version)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating Node on Appveyor takes an awful lot of time & I suppose it doesn't matter here if we're testing on Node 0.10.28 or 0.10.29. I'd advise to use the following pattern:
https://github.com/mzgol/check-dependencies/blob/6519b54cad6f8f4142947b5ec4efe46b0803fdef/appveyor.yml#L16
In this way, if the major & minor numbers match, the update is not performed.

@am11
Copy link
Contributor

am11 commented Sep 6, 2014

+1 for the Appveyor setup!

@andrew
Copy link
Contributor

andrew commented Sep 6, 2014

@deepak1556 would you care to rebase this pr so we can look at merging it?

git fetch
git coappveyor_setup
git merge master --no-ff
*fix conflicts*
git push

@deepak1556
Copy link
Contributor Author

@andrew done, can you takecare of the url to the appveyor badge in the readme before merging it ?

@am11
Copy link
Contributor

am11 commented Sep 6, 2014

Nice! thanks @deepak1556 !

Momentarily, please rebase it against upstream's master (it will remove the merge commits as well):

git remote add node-sass https://github.com/sass/node-sass/
git pull --rebase node-sass master

Revert this change: https://github.com/sass/node-sass/pull/359/files#diff-0cd0d10017fa41b04681b81e5838edacR160, then:

git commit --amend
# close the editor and finally:
git push -f
# to rewrite the history ..

@deepak1556
Copy link
Contributor Author

@am11 done.

@am11
Copy link
Contributor

am11 commented Sep 6, 2014

Thanks! 👍

@andrew LGTM! Should we merge it in?

@am11
Copy link
Contributor

am11 commented Sep 6, 2014

@deepak1556, have you considered @mzgol's comment? Wouldn't it be nice to prevent unnecessary update by replacing appveyor.yml : line 13 with:

  • ps: If (!$(node --version).StartsWith('v' + $env:nodejs_version)) {Update-NodeJsInstallation (Get-NodeJsLatestBuild $env:nodejs_version)}

andrew pushed a commit that referenced this pull request Sep 6, 2014
@andrew andrew merged commit ced1e9c into sass:master Sep 6, 2014
@andrew
Copy link
Contributor

andrew commented Sep 6, 2014

Merge-tastic!

@deepak1556
Copy link
Contributor Author

👍 , @am11 yea i did consider it, but i wanted to leave the decision to you guys :) Get-NodeJsLatestBuild returns 0.STABLE.Latest version. So when adding future versions for testing you can be sure its being tested on the stable releases instead of broken ones ;)

@deepak1556 deepak1556 deleted the appveyor_setup branch September 6, 2014 21:59
jiongle1 pushed a commit to scantist-ossops-m2/node-sass that referenced this pull request Apr 7, 2024
jiongle1 pushed a commit to scantist-ossops-m2/node-sass that referenced this pull request Apr 7, 2024
Allow trailing commas in lists. Fixes sass#359
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants