Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

bump node-gyp@4.0.0 #2681

Closed
wants to merge 1 commit into from
Closed

Conversation

protonate
Copy link

@protonate protonate commented May 31, 2019

Current version of node-gyp@3.8.0 uses fstream which is reporting a security vulnerability. node-gyp@4.0.0 removes the fstream dependency.

Current version of `node-gyp@3.8.0` uses `fstream` which is reporting a security vulnerability. `node-gyp@4.0.0 removes the `fstream` dependency.
@xzyfer
Copy link
Contributor

xzyfer commented May 31, 2019

Please search before creating new issues.

npm update fstream

@xzyfer xzyfer closed this May 31, 2019
@protonate
Copy link
Author

sorry its a little more complicated then that

fstream is no longer used with node-gyp@4.0.0 so npm update fstream is pointless and leaves a vuln in your project.

@xzyfer
Copy link
Contributor

xzyfer commented May 31, 2019

We can't use node-gyp@4 because it because old node support. When fstream is patches It'll be available via npm update.

@nschonni
Copy link
Contributor

When fstream is patches It'll be available via npm update.

It's already available, the reason why someone might be seeing this is if they have a lockfile with the old version and haven't updated the dependency as you mentioned

jiongle1 pushed a commit to scantist-ossops-m2/node-sass that referenced this pull request Apr 7, 2024
Introduces explicit order for selector unification and simplifies the
implementation.

Fixes sass#2681
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants