This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
fix(deps): upgrading node-gyp to fix vulnerability #2659
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate of a bunch of PRs. Follow #2625 |
jiongle1
pushed a commit
to scantist-ossops-m2/node-sass
that referenced
this pull request
Apr 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes the security vulnerability of the node-gyp dependancy "tar", that was present in the previous version of node-gyp. NPM audit referred to the vulnerability as being a High severity vulnerability and the risk being caused by "Arbitrary File Overwrite".
I have tested this upgrade locally in my own application that uses node-sass, and from manual testing this works well and doesn't cause any visual issues, nor are there any errors in the console.