This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Make the watcher more responsive to child changes #1873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is still slower than pre #1745 but orders of magnitude faster than what it currently is. I'm sure there is significant room for improvement in sass-graph. |
Watching for changes on files with lots of `@import`s had a significant regression in responsiveness in sass#1745. The regression was caused by calling `gaze.add` unnecessarily. We only need to call `gaze.add` on files that aren't currently being watched. At the time I confirmed that calling `gaze.add` in files that were being watched wouldn't result in a leak or multiple events being fired. I however assumed calling `gaze.add` for already watched files would be very cheap. Fixes sass#1869
xzyfer
force-pushed
the
faster-watcher
branch
from
ed290be to
38fe5c6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Watching for changes on files with lots of
@imports had asignificant regression in responsiveness in #1745.
The regression was caused by calling
gaze.addunnecessarily. Weonly need to call
gaze.addon files that aren't currently beingwatched.
At the time I confirmed that calling
gaze.addin files that werebeing watched wouldn't result in a leak or multiple events being
fired. I however assumed calling
gaze.addfor already watchedfiles would be very cheap.
Fixes #1869