This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Add a timeout to the binary fetch request #1691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a timeout to the binary fetch request as well as a useful error message. It came to light in sass#1690 that the download can block for a long time. ``` npm info lifecycle node-sass@3.8.0~install: node-sass@3.8.0 > node-sass@3.8.0 install /Usersproject-path/node_modules/node-sass > node scripts/install.js Build timed out (after 35 minutes). Marking the build as failed. ``` We see a fair amount of hung installer issues that could be related to this. The error output will give us another data point in those cases.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a 1s timeout to the binary fetch request as well as a
useful error message.
It came to light in #1690 that the download can block for a long time.
We see a fair amount of hung installer issues that could be related
to this. The error output will give us another data point in those
cases.