This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Prevent options from leaking #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xzyfer
force-pushed
the
fix/option-leakage
branch
2 times, most recently
from
108d8bb to
efd5560
Compare
The options object passed into `render` and `renderSync` is only shallow copied. This is an issue when nested objects and arrays like custom importer and functions. In the case of custom function we wrap the provided function. This wrapped version replaces the provided one which can then leak back into the calling code. This is an issue if `render*` is called in a loop like in gulp-sass. Fixes sass#1168
xzyfer
force-pushed
the
fix/option-leakage
branch
from
efd5560 to
7ac6c2e
Compare
| @@ -535,19 +535,18 @@ describe('api', function() { | |||
| }); | |||
| }); | |||
|
|
|||
| it('should copy all options properties', function(done) { | |||
| it('should wrap importer options', function(done) { | |||
There was a problem hiding this comment.
This test didn't make sense. It was actually asserting this issue existed.
jiongle1
pushed a commit
to scantist-ossops-m2/node-sass
that referenced
this pull request
Apr 7, 2024
Emulate Ruby Sass' url() parsing semantics
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The options object passed into
renderandrenderSyncis onlyshallow copied. This is an issue when nested objects and arrays like
custom importer and functions. In the case of custom function we
wrap the provided function. This wrapped version replaces the provided
one which can then leak back into the calling code. This is an issue
if
render*is called in a loop like in gulp-sass.Fixes #1168