Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

update setup steps to comply with instructions #1586

Closed
wants to merge 2 commits into from

Conversation

mohuk
Copy link
Contributor

@mohuk mohuk commented Jun 10, 2016

package.json will not be created without npm init and a --save is required to append the installed version of package onto the package.json

package.json will not be created without npm init and a --save is required to append the installed version of package onto the package.json
@@ -81,6 +81,7 @@ Firstly create a clean work space.
```sh
mkdir \temp1
cd \temp1
npm init
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be npm init --yes so you're prompted for unnecessary input.

@xzyfer
Copy link
Contributor

xzyfer commented Jun 12, 2016

Alternatively, a better approach would be to move the section starting with

Note which version was installed by opening the `package.json` file with a text editor.

And replace it with npm ls node-sass

@mohuk
Copy link
Contributor Author

mohuk commented Jun 13, 2016

There is no need of doing an npm init --yes if we are doing npm ls node-sass because npm ls will list the package installed irrespective of the package.json file's existence. I think npm ls node-sass should suffice.

@xzyfer
Copy link
Contributor

xzyfer commented Jun 13, 2016

Correct, this is what I was suggesting.
On 13 Jun 2016 5:44 PM, "Mohammad Umair Khan" notifications@github.com
wrote:

There is no need to doing an npm init --yes if we are doing npm ls
node-sass because npm ls will list the package installed irrespective of
the package.json file's existence. I think npm ls node-sass should
suffice.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#1586 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAjZWHrhPyWkNbk5UVgokQxKDnpb3Zmsks5qLQpQgaJpZM4IyriN
.

@nschonni
Copy link
Contributor

LGTM, but the output sample of the npm ls node-sass might be helpful to replace the old json example

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants