assert(a === b) => assert.strictEqual(a, b) #1307

saper · 2015-12-19T23:59:37Z

When the test fails, we are getting actual
values in the error message instead of

+ true
- false

When the test fails, we are getting actual values in the error message instead of + true = false

xzyfer · 2015-12-22T03:04:57Z

Nice.

Use assert.strictEqual in tests for better error output

assert(a === b) => assert.strictEqual(a, b)

093b912

When the test fails, we are getting actual values in the error message instead of + true = false

saper added this to the next.patch milestone Dec 20, 2015

saper added the Feature - Test label Dec 20, 2015

saper self-assigned this Dec 20, 2015

saper added the Dev - Needs Review label Dec 20, 2015

xzyfer added Dev - Reviewed and removed Dev - Needs Review labels Dec 22, 2015

xzyfer added a commit that referenced this pull request Dec 22, 2015

Merge pull request #1307 from saper/strict-equal

7128b45

Use assert.strictEqual in tests for better error output

xzyfer merged commit 7128b45 into sass:master Dec 22, 2015

xzyfer modified the milestone: next.patch Sep 4, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

assert(a === b) => assert.strictEqual(a, b) #1307

assert(a === b) => assert.strictEqual(a, b) #1307

saper commented Dec 19, 2015

xzyfer commented Dec 22, 2015

assert(a === b) => assert.strictEqual(a, b) #1307

assert(a === b) => assert.strictEqual(a, b) #1307

Conversation

saper commented Dec 19, 2015

xzyfer commented Dec 22, 2015