-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Incorrect implementation of map.get and map.set #3022
Comments
These are two different APIs. The map.* functions are part of map module
which is not supported by node-sass as state in the documentation.
…On Thu, 5 Nov 2020, 12:23 am Jeroen Meeus, ***@***.***> wrote:
Hey,
As noted in #2890 <#2890> the get
and set methods on a map are implemented as map-get and map-set.
However the official sass-lang pages show map.get and map.set:
https://sass-lang.com/documentation/values/maps#look-up-a-value
Either those documentation pages should reflect the actual implementation,
or the implementation should support the official syntax.
If you point me into the right direction I'm more then willing to help out.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3022>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAENSWFIXPTJG2HXERYB67LSOFIWJANCNFSM4TKBRFJA>
.
|
Documentation issues should be raised with the sass/sass-site repo.
…On Thu, 5 Nov 2020, 12:26 am Michael Mifsud, ***@***.***> wrote:
These are two different APIs. The map.* functions are part of map module
which is not supported by node-sass as state in the documentation.
On Thu, 5 Nov 2020, 12:23 am Jeroen Meeus, ***@***.***>
wrote:
> Hey,
>
> As noted in #2890 <#2890> the
> get and set methods on a map are implemented as map-get and map-set.
>
> However the official sass-lang pages show map.get and map.set:
> https://sass-lang.com/documentation/values/maps#look-up-a-value
>
> Either those documentation pages should reflect the actual
> implementation, or the implementation should support the official syntax.
>
> If you point me into the right direction I'm more then willing to help
> out.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#3022>, or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAENSWFIXPTJG2HXERYB67LSOFIWJANCNFSM4TKBRFJA>
> .
>
|
Is there a reason why they are not supported? |
The feature landed after active development on LibSass was halted. This
project is now deprecated. We suggest migrating to the sass package for
full features.
…On Thu, 5 Nov 2020, 6:00 pm Jeroen Meeus, ***@***.***> wrote:
Is there a reason why they are not supported?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3022 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAENSWBBJZEOS6PA23ECKF3SOJEPXANCNFSM4TKBRFJA>
.
|
@xzyfer |
Hey,
As noted in #2890 the get and set methods on a map are implemented as
map-get
andmap-set
.However the official sass-lang pages show
map.get
andmap.set
:https://sass-lang.com/documentation/values/maps#look-up-a-value
Either those documentation pages should reflect the actual implementation, or the implementation should support the official syntax.
If you point me into the right direction I'm more then willing to help out.
The text was updated successfully, but these errors were encountered: