Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Incorrect implementation of map.get and map.set #3022

Closed
pinoniq opened this issue Nov 4, 2020 · 5 comments
Closed

Incorrect implementation of map.get and map.set #3022

pinoniq opened this issue Nov 4, 2020 · 5 comments

Comments

@pinoniq
Copy link

pinoniq commented Nov 4, 2020

Hey,

As noted in #2890 the get and set methods on a map are implemented as map-get and map-set.

However the official sass-lang pages show map.get and map.set:
https://sass-lang.com/documentation/values/maps#look-up-a-value

Either those documentation pages should reflect the actual implementation, or the implementation should support the official syntax.

If you point me into the right direction I'm more then willing to help out.

@xzyfer
Copy link
Contributor

xzyfer commented Nov 4, 2020 via email

@xzyfer
Copy link
Contributor

xzyfer commented Nov 4, 2020 via email

@nschonni nschonni closed this as completed Nov 4, 2020
@pinoniq
Copy link
Author

pinoniq commented Nov 5, 2020

Is there a reason why they are not supported?

@xzyfer
Copy link
Contributor

xzyfer commented Nov 5, 2020 via email

@Frimlik
Copy link

Frimlik commented Apr 15, 2021

These are two different APIs. The map.* functions are part of map module which is not supported by node-sass as state in the documentation.

On Thu, 5 Nov 2020, 12:23 am Jeroen Meeus, @.***> wrote: Hey, As noted in #2890 <#2890> the get and set methods on a map are implemented as map-get and map-set. However the official sass-lang pages show map.get and map.set: https://sass-lang.com/documentation/values/maps#look-up-a-value Either those documentation pages should reflect the actual implementation, or the implementation should support the official syntax. If you point me into the right direction I'm more then willing to help out. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3022>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAENSWFIXPTJG2HXERYB67LSOFIWJANCNFSM4TKBRFJA .

@xzyfer
Could you, please, provide a link to the documentation? I'm also pretty lost in the - and . notation.
Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants