Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Installation writes to standard error when no error occurs #1801

Closed
mark-raymond opened this issue Nov 14, 2016 · 6 comments
Closed

Installation writes to standard error when no error occurs #1801

mark-raymond opened this issue Nov 14, 2016 · 6 comments

Comments

@mark-raymond
Copy link

mark-raymond commented Nov 14, 2016

Since node-sass 3.11.3, installation writes to standard error, even when no error occurs. This is a problem on some build servers (at least including TeamCity), as output to standard error fails the build.

Reproduction steps:

  • Copy packages.json from attached zip to an empty folder
  • Run npm install --loglevel=error >npm.log 2>npm.err

Expected result:

  • Nothing written to npm.err

Actual result:

Version information:

  • NPM version (npm -v): 3.10.9
  • Node version (node -v): 4.4.7
  • Node Process (node -p process.versions):
{ http_parser: '2.5.2',
  node: '4.4.7',
  v8: '4.5.103.36',
  uv: '1.8.0',
  zlib: '1.2.8',
  ares: '1.10.1-DEV',
  icu: '56.1',
  modules: '46',
  openssl: '1.0.2h' }
  • Node Platform (node -p process.platform): win32
  • Node architecture (node -p process.arch): x64
  • node-sass version (node -p "require('node-sass').info"):
node-sass       3.12.2  (Wrapper)       [JavaScript]
libsass         3.3.6   (Sass Compiler) [C/C++]
  • npm node-sass versions (npm ls node-sass):
C:\Work\node-sass-bug
`-- node-sass@3.12.2
xzyfer added a commit that referenced this issue Nov 14, 2016
Looks the default of stderr is causing issue for some CI servers.

Fixes #1801
xzyfer added a commit that referenced this issue Nov 14, 2016
Looks the default of stderr is causing issue for some CI servers.

Fixes #1801
@martincostello
Copy link

I'm still having this issue in AppVeyor through PowerShell with 3.12.5 (build).

I've worked around it by fixing node-sass going back to 3.10.1.

@saper
Copy link
Member

saper commented Nov 15, 2016

This an issue with PowerShell, it assumes that if anything got posted on standard error the command failed. UNIX-like systems need an error code for that.

@martincostello
Copy link

But why is node-sass now outputting to standard error in newer versions when there is nothing apparently wrong? It only seems to be downloading a file.

@xzyfer
Copy link
Contributor

xzyfer commented Nov 15, 2016

We moved our logging to the same logging library as npm, which by default logs to stderr. It's caused some issue so we're reverting it shortly.

@xzyfer
Copy link
Contributor

xzyfer commented Nov 15, 2016

@martincostello released v3.13.0 which should now only log to stderr if there is an error

@martincostello
Copy link

@xzyfer Fixed now - thank you :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants