This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #872 from xzyfer/release/3.0.0-beta.6
Release 3.0.0 beta.6
- Loading branch information
Showing
3 changed files
with
4 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule libsass
updated
21 files
+2 −0 | .travis.yml | |
+9 −3 | Makefile | |
+1 −0 | Readme.md | |
+9 −0 | ast.cpp | |
+50 −4 | ast.hpp | |
+2 −2 | backtrace.hpp | |
+1 −1 | constants.cpp | |
+195 −69 | debugger.hpp | |
+2 −6 | environment.hpp | |
+50 −10 | eval.cpp | |
+47 −10 | expand.cpp | |
+14 −5 | functions.cpp | |
+132 −135 | json.cpp | |
+25 −10 | lexer.hpp | |
+19 −17 | parser.cpp | |
+9 −3 | parser.hpp | |
+1 −0 | position.hpp | |
+19 −14 | prelexer.cpp | |
+3 −3 | script/ci-build-libsass | |
+24 −1 | util.cpp | |
+4 −0 | util.hpp |
ea3430e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just finished tracking a bug: I believe this revision change is breaking my deployment to heroku due to the release download not yet being available. Am I incorrect?
The url heroku tried downloading:
The url I found manually via browsing the releases page:
The only difference is ...beta.5/linux... vs ...beta.6/linux...
ea3430e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious. How are you installing node-sass? There is no 3.0.0-beta.6 tag yet so you should not be getting this changes unless you're installing from git.
ea3430e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My apologies, I was unaware of how releases were handled. I needed v3 and was referencing master directly hence the error.
I will raise an issue next time too, instead of commenting on the commit directly.
Thanks for the quick response.
ea3430e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right that'll always end in pain. I suggest
npm install node-sass@beta
for now 😄