Merge pull request #2865 from mgreter/bugfix/remove-ci-sass-version-flag

Remove passing version flag to spec runner
sass · Apr 12, 2019 · 68d3528 · 68d3528
2 parents 28bbd0e + 689295a
commit 68d3528
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/GNUmakefile.am b/GNUmakefile.am
@@ -46,7 +46,7 @@ TESTS = $(SASS_SPEC_PATH)/sass-spec.rb
 RB_LOG_COMPILER = ./script/tap-runner
 AM_RB_LOG_FLAGS = $(RUBY)
 
-SASS_TEST_FLAGS = -V 3.5 --impl libsass
+SASS_TEST_FLAGS = --impl libsass
 SASS_TEST_FLAGS += -r $(SASS_SPEC_PATH)
 SASS_TEST_FLAGS += -c $(top_srcdir)/tester$(EXEEXT)
 AM_TESTS_ENVIRONMENT = TEST_FLAGS='$(SASS_TEST_FLAGS)'

diff --git a/Makefile b/Makefile
@@ -276,13 +276,13 @@ version: $(SASSC_BIN)
 test: test_build
 
 test_build: $(SASSC_BIN)
-	$(RUBY_BIN) $(SASS_SPEC_PATH)/sass-spec.rb -V 3.5 -c $(SASSC_BIN) --impl libsass $(LOG_FLAGS) $(SASS_SPEC_PATH)/$(SASS_SPEC_SPEC_DIR)
+	$(RUBY_BIN) $(SASS_SPEC_PATH)/sass-spec.rb -c $(SASSC_BIN) --impl libsass $(LOG_FLAGS) $(SASS_SPEC_PATH)/$(SASS_SPEC_SPEC_DIR)
 
 test_full: $(SASSC_BIN)
-	$(RUBY_BIN) $(SASS_SPEC_PATH)/sass-spec.rb -V 3.5 -c $(SASSC_BIN) --impl libsass --run-todo $(LOG_FLAGS) $(SASS_SPEC_PATH)/$(SASS_SPEC_SPEC_DIR)
+	$(RUBY_BIN) $(SASS_SPEC_PATH)/sass-spec.rb -c $(SASSC_BIN) --impl libsass --run-todo $(LOG_FLAGS) $(SASS_SPEC_PATH)/$(SASS_SPEC_SPEC_DIR)
 
 test_probe: $(SASSC_BIN)
-	$(RUBY_BIN) $(SASS_SPEC_PATH)/sass-spec.rb -V 3.5 -c $(SASSC_BIN) --impl libsass --probe-todo $(LOG_FLAGS) $(SASS_SPEC_PATH)/$(SASS_SPEC_SPEC_DIR)
+	$(RUBY_BIN) $(SASS_SPEC_PATH)/sass-spec.rb -c $(SASSC_BIN) --impl libsass --probe-todo $(LOG_FLAGS) $(SASS_SPEC_PATH)/$(SASS_SPEC_SPEC_DIR)
 
 clean-objects: | lib
 	-$(RM) lib/*.a lib/*.so lib/*.dll lib/*.la

diff --git a/appveyor.yml b/appveyor.yml
@@ -71,7 +71,7 @@ test_script:
       }
       $env:TargetPath = Join-Path $pwd.Path $env:TargetPath
       If (Test-Path "$env:TargetPath") {
-        ruby sass-spec/sass-spec.rb -V 3.5 --probe-todo --impl libsass -c $env:TargetPath -s sass-spec/spec
+        ruby sass-spec/sass-spec.rb --probe-todo --impl libsass -c $env:TargetPath -s sass-spec/spec
         if(-not($?)) {
           echo "sass-spec tests failed"
           exit 1

diff --git a/docs/build-on-windows.md b/docs/build-on-windows.md
@@ -130,7 +130,7 @@ cd libsass
 REM set PATH=%PATH%;%PROGRAMFILES%\MSBuild\12.0\Bin
 msbuild /m:4 /p:Configuration=Release win\libsass.sln
 REM running the spec test-suite manually (needs ruby and minitest gem)
-ruby sass-spec\sass-spec.rb -V 3.5 -c win\bin\sassc.exe -s --impl libsass sass-spec/spec
+ruby sass-spec\sass-spec.rb -c win\bin\sassc.exe -s --impl libsass sass-spec/spec
 cd ..
 ```