Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update "call" parameter to $function #2948

Merged
merged 1 commit into from
Jul 19, 2019
Merged

fix: Update "call" parameter to $function #2948

merged 1 commit into from
Jul 19, 2019

Conversation

nschonni
Copy link
Collaborator

@nschonni nschonni commented Jul 17, 2019 •
edited
Loading

@mgreter mgreter self-requested a review July 18, 2019 01:46
mgreter
mgreter approved these changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@mgreter mgreter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nschonni nschonni force-pushed the fix--Update-"call"-parameter-to-$function branch from d96afd2 to d5d30da Compare July 18, 2019 04:40
@nschonni
Copy link
Collaborator Author

@mgreter sorry, I just realized I included the commit from #2947, but I rebased it out

@nschonni nschonni merged commit 1587a2a into sass:master Jul 19, 2019
@nschonni nschonni deleted the fix--Update-"call"-parameter-to-$function branch July 19, 2019 00:29
@nschonni nschonni mentioned this pull request Jul 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgreter mgreter mgreter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

call()'s first argument should be named $function
2 participants
@nschonni @mgreter