Ensure sass.hpp is included before system headers #2817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, system headers on Solaris will export the SEC macro, which clashes with the SEC constant defined in src/units.hpp. See 4599662.
|
Looks good to me |
|
Honestly I think even a simple comment would go a long way to stopping this regressing again. Memories are short. |
|
Honestly I think even a simple comment would go a long way to stopping this regressing again. Memories are short.
Where would it go? Would it have to be repeated once per file?
|
|
Yep, that's fine
…On Fri., 1 Feb. 2019, 9:03 pm Alyssa Ross ***@***.*** wrote:
> Honestly I think even a simple comment would go a long way to stopping
this regressing again. Memories are short.
Where would it go? Would it have to be repeated once per file?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2817 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAjZWNttJVCj4-TJlzER28AMIjwipKDvks5vJBDagaJpZM4Z-XuA>
.
|
xzyfer
approved these changes
Feb 1, 2019
|
Thanks |
|
Thank you! While I'm here, any news on a release? |
|
I'm on vacation through February so probably not for a couple weeks
…On Sat., 2 Feb. 2019, 12:55 am Alyssa Ross ***@***.*** wrote:
Thank you! While I'm here, any news on a release?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#2817 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAjZWBWpEBBPn-bjASvHncwPwI0FRT8Zks5vJEdAgaJpZM4Z-XuA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, system headers on Solaris will export the SEC macro, which clashes with the SEC constant defined in src/units.hpp.
See #2519.
I wonder if there might be a better way to address this going forward... This has already been fixed once in the past, but has crept back. Perhaps we could use a compiler flag, rather than using sass.hpp to undefine the macro.
Thoughts?