Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use case-insensitive lookup to parse colors. #2463

Merged
merged 1 commit into from
Aug 16, 2017
Merged

Use case-insensitive lookup to parse colors. #2463

merged 1 commit into from
Aug 16, 2017

Conversation

asottile
Copy link
Member

@asottile asottile commented Aug 8, 2017 •
edited by xzyfer
Loading

@asottile asottile mentioned this pull request Aug 8, 2017
Closed
@mgreter
Copy link
Contributor

mgreter commented Aug 8, 2017

LGTM, since colors should always only contain ASCII characters. THX!

@asottile
Copy link
Member Author

The build seems to have timed out? Perhaps it can be restarted

@xzyfer
Copy link
Contributor

xzyfer commented Aug 15, 2017

@asottile bumped the build

@nschonni
Copy link
Collaborator

Failure seems related to travis-ci/travis-ci#6307
I'll try some fixes separately

@xzyfer
Copy link
Contributor

xzyfer commented Aug 16, 2017

@nschonni I think that is a red herring. The build fails due to the proxy being down

Fetching PR 2463
Travis rate limit on github exceeded
Retrying via 'special purpose proxy'
curl: (7) Failed to connect to libsass.ocbnet.ch port 80: Connection refused
The command "./script/ci-build-libsass" exited with 7.

Everything else is a consequence on that. I'll update LibSass to use the heroku proxy I created for node-sass to stop this ever happening again.

xzyfer
xzyfer approved these changes Aug 16, 2017
View reviewed changes
Copy link
Contributor

@xzyfer xzyfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@xzyfer xzyfer merged commit b6bc02e into sass:master Aug 16, 2017
@asottile asottile deleted the issue_2462 branch August 16, 2017 18:41
@xzyfer xzyfer added this to the 3.5.0.beta.4 milestone Aug 17, 2017
xzyfer pushed a commit that referenced this pull request Aug 17, 2017
@asottile @xzyfer
Use case-insensitive lookup to parse colors. (#2463)
66e3409 
Fixes #2462
Spec sass/sass-spec#1161
@xzyfer
Copy link
Contributor

xzyfer commented Aug 17, 2017

Backported to 3.4

mgreter pushed a commit to mgreter/libsass that referenced this pull request Oct 6, 2017
@asottile @mgreter
Use case-insensitive lookup to parse colors. (sass#2463)
f100ae1 
Fixes sass#2462
Spec sass/sass-spec#1161
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xzyfer xzyfer xzyfer approved these changes

Assignees
No one assigned
Labels
Back port to 3.4 stable Bug - Confirmed Dev - PR Ready Dev - Test Written
Projects
None yet
Milestone
3.5.0.beta.4
Development

Successfully merging this pull request may close these issues.
5 participants
@asottile @mgreter @xzyfer @nschonni @saper