Performance improvements #2339
Merged
Performance improvements #2339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xzyfer
approved these changes
Feb 21, 2017
We can directly parse them into Value Nodes!
Use result from find whenever possible. Avoids the need to fetch key bucket twice.
By testing the most common cases first we can avoid the pretty expensive overhead for the more complex cases. This adds a bit of code overhead trading for better performance.
mgreter
force-pushed
the
perf-refactor/loops-and-env
branch
from
db77a5e
to
ca70b9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used https://github.com/pcorey/JuliaSass/blob/master/julia.scss to profile.
Improves the above runtime by a factor of two or more.
Of the rest ~25% are heap (de-)allocs, ~10% searching in maps, ~5% casts, ~3% ref count overhead.