Refactor selector list and schema handling #2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgreter
force-pushed
the
refactor/selector-schema
branch
2 times, most recently
from
5bd51c3 to
d95df9e
Compare
mgreter
force-pushed
the
refactor/selector-schema
branch
26 times, most recently
from
3cd7534 to
608edba
Compare
mgreter
force-pushed
the
refactor/selector-schema
branch
from
608edba to
44ddf7c
Compare
xzyfer
approved these changes
Jan 21, 2017
This greatly simplifies the handling with selectors. We always store a `Selector_List` and handle interpolation as needed. Selectors are evaluated in expand, which might be in a for loop. Therefore we either eval the list or the schema to get the result (caching might be possible).
This exposed some ambiguity with the `type` method. Renamed some methods to avoid the name clash for now.
mgreter
force-pushed
the
refactor/selector-schema
branch
from
7d13033 to
083e92c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the heels of the recent code cleanups, this one fixes a IMO rather big ambiguity. AST nodes holding selectors referenced the base selector class. This lead to multiple issues which were generally solved by using dynamic casts. This PR changes the implementation that Selector Schemas are always part of a Selector List (more precisely, a Selector List can have a Schema). When expanding/evaluating nodes we act accordingly. This is still not perfect, but allows us to carry a Selector List type around, instead of a base class. Since this class is final we know that it will itself evaluate to a selector list and so on.