Fix broken link #2105
Merged
Fix broken link #2105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -88,5 +88,5 @@ Our MIT license is designed to be as simple, and liberal as possible. | |||
| [@mgreter]: https://github.com/mgreter | |||
| [@xzyfer]: https://github.com/xzyfer | |||
|
|
|||
| sass2scss was originally written by [Marcel Greter](@mgreter) | |||
| sass2scss was originally written by [Marcel Greter](https://github.com/mgreter) | |||
There was a problem hiding this comment.
The proper fix for this is to move the reference links below this line.
[@hcatlin]: https://github.com/hcatlin
[@akhleung]: https://github.com/akhleung
[@chriseppstein]: https://github.com/chriseppstein
[@nex3]: https://github.com/nex3
[@mgreter]: https://github.com/mgreter
[@xzyfer]: https://github.com/xzyfer
There was a problem hiding this comment.
If i move the reference links to the end of the file, the link [Marcel Greater](@mgreter) still don't works. It only seems to work if i write it like this [@mgreter].
There was a problem hiding this comment.
Correct, the () are a typo it should be []. You may not even need to move the references.
|
Thanks @MoritzKn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.