Include <cstdint> unconditionally #1835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need <cstdint> a.k.a <stdint.h> to access width-based integer types like uint_fast8_t
saper
changed the title
|
Not sure what PR ready means ... but hey, green looks so much better! |
|
It's mostly just usefull for issues, but I tend to flag PRs that I feel can be "blindly" merged if needed. Just a minor nitpick, a comment in the source for such conditionals would be usefull. Other than that 👍 |
|
I'm all for this. We've talked bout VS2013 before. The only reason we haven't addressed it yet is that we don't have a plan for testing it in parallel with VS2015. |
|
This change removes VS version conditional - we should always include this header because we use width int types. I tested it with VS2013 and VS2015 was tested by appveyor. We should be able to run tests for VS2015 as an additional environment if we want. |
|
Rebuilding. If CI is still happy 🚢 |
xzyfer
added a commit
that referenced
this pull request
Jan 12, 2016
Include <cstdint> unconditionally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow up to #1721