win: VS to emit DLL which exports symbols #1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
//cc @mgreter |
am11
force-pushed
the
master
branch
4 times, most recently
from
dcd27f4 to
939fd5c
Compare
|
I have no objections. |
🚀 |
At present if we run `dumpbin /exports win/bin/libsass.dll`, we get:
```ps
C:\Users\Adeel\source\repos\libsass> dumpbin.exe /exports win/bin/libsass.dll
Microsoft (R) COFF/PE Dumper Version 14.00.23506.0
Copyright (C) Microsoft Corporation. All rights reserved.
Dump of file win/bin/libsass.dll
File Type: DLL
Summary
7000 .data
1000 .gfids
5000 .rdata
3000 .reloc
1000 .rsrc
13000 .text
```
No exported functions.
With this change, we get the entire set of
exported functions. Note that it only affects the the `DLL` and not
shared `LIB` which we can build as:
`msbuild win/libsass.sln /p:LIBSASS_STATIC_LIB=1`.
xzyfer
added a commit
that referenced
this pull request
Dec 30, 2015
VS to emit DLL which exports symbols
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present if we run
dumpbin /exports win/bin/libsass.dll, we get:No exported functions.
With this change, we get the entire set of
exported functions. Note that it only affects the the
DLLand notshared
LIBwhich we can build as:msbuild win/libsass.sln /p:LIBSASS_STATIC_LIB=1.