Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

str-slice() should allow very negative $start-at values #2920

Closed
nex3 opened this issue Jun 25, 2019 · 3 comments · Fixed by #2951
Closed

str-slice() should allow very negative $start-at values #2920

nex3 opened this issue Jun 25, 2019 · 3 comments · Fixed by #2951
Labels
Compatibility - P3 Minorly important for compatibility with the Sass spec and ecosystem

Comments

@nex3
Copy link
Contributor

nex3 commented Jun 25, 2019

str-slice("cde", -100) should return "cde", but in LibSass it throws an error with the text utf8::not_enough_room.
@nex3 nex3 added the Compatibility - P3 Minorly important for compatibility with the Sass spec and ecosystem label Jun 25, 2019
nschonni added a commit to nschonni/libsass that referenced this issue Jul 17, 2019
@nschonni
fix: str-slice can't start at 0
c4d97e4 
See sass/sass-spec#1441
Closes sass#2920
@nschonni nschonni mentioned this issue Jul 17, 2019
Closed
nschonni added a commit to nschonni/libsass that referenced this issue Jul 18, 2019
@nschonni
fix: str-slice can't start at 0
1c2ae95 
See sass/sass-spec#1441
Closes sass#2920
@nschonni nschonni mentioned this issue Jul 18, 2019
Merged
@Erutan409
Copy link

@nex3 @nschonni Is this in the latest and greatest, because I'm currently running into this issue. It's hit or miss, though. If it's compiled with the sass loader from the vue loader, everything works fine. But, if I try compiling directly with the sass loader, I get this error.

@nschonni
Copy link
Collaborator

If you're using node-sass it isn't included yet, and wont be till the next major version

@Erutan409
Copy link

@nschonni Thank you for the heads up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Compatibility - P3 Minorly important for compatibility with the Sass spec and ecosystem
Projects
None yet
Milestone
No milestone
3 participants
@nex3 @nschonni @Erutan409