Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat FF, CR, and CR LF as LF #2843

Closed
nex3 opened this issue Mar 15, 2019 · 1 comment · Fixed by #2849
Closed

Treat FF, CR, and CR LF as LF #2843

nex3 opened this issue Mar 15, 2019 · 1 comment · Fixed by #2849

Comments

@nex3
Copy link
Contributor

nex3 commented Mar 15, 2019 •
edited
Loading

The CSS spec says that "U+000D CARRIAGE RETURN (CR) code points, U+000C FORM FEED (FF) code points, or pairs of U+000D CARRIAGE RETURN (CR) followed by U+000A LINE FEED (LF)" should be treated as U+000A LINE FEED characters, but LibSass seems to treat them like any other character in some circumstances.

In particular, all of these characters (or character sequences) are passed through as-is if they appear in comments. If they're used to terminate a line in the indented syntax, CR and CR LF work as expected but FF fails.
@nex3 nex3 changed the title Treat LF as a newline Treat FF, CR, and CR LF as LF Mar 15, 2019
@nex3 nex3 mentioned this issue Mar 15, 2019
Merged
@nex3
Copy link
Contributor Author

nex3 commented Mar 15, 2019

sass/sass-spec#1360 adds specs for this.

glebm added a commit to glebm/libsass that referenced this issue Mar 25, 2019
@glebm
Newlines: Parse \f and normalize in comments
0ade491 
Also moves the `normalize*` functions and `rtrim` to a separate object
file, so they can be unit tested quickly and easily.

I'm not entirely sure if the new `normalize_newlines` method is called
in the right places.

Refs sass#2843
@glebm glebm mentioned this issue Mar 25, 2019
Merged
glebm added a commit to glebm/libsass that referenced this issue Mar 25, 2019
@glebm
Newlines: Parse \f and normalize in comments
6ed2c98 
Also moves the `normalize*` functions and `rtrim` to a separate object file, so that they can be unit tested quickly and easily.

I'm not entirely sure that the new `normalize_newlines` method is called in the right places.

Refs sass#2843
glebm added a commit to glebm/libsass that referenced this issue Mar 25, 2019
@glebm
Newlines: Parse \f and normalize in comments
b1710cb 
Also moves the `normalize*` functions and `rtrim` to a separate object file, so that they can be unit tested quickly and easily.

I'm not entirely sure that the new `normalize_newlines` method is called in the right places.

Refs sass#2843
glebm added a commit to glebm/libsass that referenced this issue Mar 25, 2019
@glebm
Newlines: Parse \f and normalize in comments
c38347b 
Also moves the `normalize*` functions and `rtrim` to a separate object file, so that they can be unit tested quickly and easily.

Refs sass#2843
glebm added a commit to glebm/libsass that referenced this issue Mar 25, 2019
@glebm
Newlines: Parse \f and normalize in comments
c8d183e 
Also:

1. Moves the `normalize*` functions and `rtrim` to a separate object file,
   so that they can be unit tested quickly and easily.
2. Changes `string_to_output` to also replace `\r\n`, fixing Windows tests.
3. Improves other `normalize_*` functions and adds tests.

Refs sass#2843
glebm added a commit to glebm/libsass that referenced this issue Mar 25, 2019
@glebm
Newlines: Parse \f and normalize in comments
ad22078 
Also:

1. Moves the `normalize*` functions and `rtrim` to a separate object file,
   so that they can be unit tested quickly and easily.
2. Changes `string_to_output` to also replace `\r\n`, fixing Windows tests.
3. Improves other `normalize_*` functions and adds tests.

Refs sass#2843

sass-spec PRs:

1. Bug fixes to make it run: sass/sass-spec#1365
2. Enabling the newly passing tests: sass/sass-spec#1366
xzyfer pushed a commit that referenced this issue Mar 25, 2019
@glebm @xzyfer
Newlines: Parse \f and normalize in comments (#2849)
6df8cd9 
Also:

1. Moves the `normalize*` functions and `rtrim` to a separate object file,
   so that they can be unit tested quickly and easily.
2. Changes `string_to_output` to also replace `\r\n`, fixing Windows tests.
3. Improves other `normalize_*` functions and adds tests.

Refs #2843

sass-spec PRs:

1. Bug fixes to make it run: sass/sass-spec#1365
2. Enabling the newly passing tests: sass/sass-spec#1366
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Newlines: Parse \f and normalize in comments glebm/libsass
1 participant
@nex3