-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS custom properties(variables) not rendered correctly in libsass 3.5.2 #2620
Comments
The current behaviour is correct. Sass is not allowed to evaluate the values of custom properties. The one exception is string interpolation. :root {
--TEST: #{$theme-primary};
} |
@xzyfer Thanks for your follow up. |
@xzyfer After reinstalling the node-sass 4.8.3 allow again the follow behaviour which you described as "not allowed" is allowing again. I am not sure what dependency making it happening by chance. SCSS
expected
result
|
Run |
@xzyfer I have just confirmed it is the only version installed:
|
* Update to Node 10 (10.4.0) and npm 6.1.0 * pull in node-sass 4.9 which has node 10 support * allow config as a builtin, even though it's not? * update to fsevents 1.2.4 for node 10 support * fixup css that broke with node-sass 4.9 This also shows a bunch of deprecation warnings that look like they'll be removed in 4.9.1. See sass/node-sass#2362 Specifically https://github.com/sass/node-sass/issues/2362\#issuecomment-392118915 * touch node_modules after generating shrinkwrap * use string interpolation on css variable values. see sass/libsass#2620 * Removed "cash-touch" dependency, use instead a multi-platform NodeJS equivalent of "touch node_modules"
The sass $variable is not recognized and being output directly in the libsas 3.5.2.
Details as follow:
input.scss
Reference: [#2244]
Actual results
libsass 3.5.2
Expected result
libsass 3.5.0.beta.2
version info:
Last known good version
The text was updated successfully, but these errors were encountered: