Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS custom properties with rgba cause an error #2561

Closed
ArielGueta opened this issue Feb 12, 2018 · 3 comments
Closed

CSS custom properties with rgba cause an error #2561

ArielGueta opened this issue Feb 12, 2018 · 3 comments

Comments

@ArielGueta
Copy link

Using CSS custom properties with rgba in scss files cause an error when trying to compile it.

Example code:

.foo {
  color: rgba(var(--colorvar), 1)
}

Error: argument $color of rgba($color, $alpha) must be a color

$ node-sass --version
node-sass 4.7.2 (Wrapper) [JavaScript]
libsass 3.5.0.beta.2 (Sass Compiler) [C/C++]

@nschonni
Copy link
Collaborator

This is resolved in #2244 but node-sass hasn't been updated to use a version of libsass that includes the patch

@mgreter
Copy link
Contributor

mgreter commented Feb 15, 2018

AFAICS this was not correctly resolved for this case ...

@mgreter mgreter reopened this Feb 15, 2018
@xzyfer xzyfer self-assigned this Feb 20, 2018
xzyfer added a commit to xzyfer/libsass that referenced this issue Feb 20, 2018
@xzyfer
Copy link
Contributor

xzyfer commented Feb 20, 2018

@mgreter is correct. The short-hand signature for rgba was not covered in #2244 by mistake. This is addressed in #2564

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants